Html script element supports method #7008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Sep 2, 2021
horo-t
commented
Sep 2, 2021
horo-t
force-pushed
the
HTMLScriptElement_supports
branch
from
225c56e
to
1cfe8f2
Compare
horo-t
added a commit
to horo-t/import-maps
that referenced
this pull request
Sep 2, 2021
The script.supports() method will be introduced by whatwg/html#7008. script.supports('importmap') must return true when supported. Fixes WICG#171
horo-t
added a commit
to horo-t/alternate-loading-modes
that referenced
this pull request
Sep 2, 2021
The script.supports() method will be introduced by whatwg/html#7008. script.supports('speculationrules') must return true when supported.
hiroshige-g
reviewed
Sep 2, 2021
hiroshige-g
reviewed
Sep 2, 2021
|
Also looks good to me. +1 > @domenic for final check. |
domenic
reviewed
Sep 2, 2021
source
Outdated
| @@ -58589,6 +58591,30 @@ interface <dfn interface>HTMLScriptElement</dfn> : <span>HTMLElement</span> { | |||
| <code data-x="dom-innerHTML">innerHTML</code> and <code data-x="dom-outerHTML">outerHTML</code> | |||
| attributes, they do not execute at all.</p> | |||
|
|
|||
|
|
|||
| <dl class="domintro"> | |||
There was a problem hiding this comment.
We generally keep the domintro contents together. So I think you can merge this with the previous one for script.text.
3 tasks
horo-t
commented
Sep 3, 2021
source
Outdated
| @@ -58589,6 +58591,30 @@ interface <dfn interface>HTMLScriptElement</dfn> : <span>HTMLElement</span> { | |||
| <code data-x="dom-innerHTML">innerHTML</code> and <code data-x="dom-outerHTML">outerHTML</code> | |||
| attributes, they do not execute at all.</p> | |||
|
|
|||
|
|
|||
| <dl class="domintro"> | |||
|
Looks good. |
|
@horo-t please remember to file Mozilla and WebKit bugs, and update the original post to link to them. |
Filed bugs and updated the original post. |
horo-t
added a commit
to horo-t/import-maps
that referenced
this pull request
Sep 6, 2021
The HTMLScriptElement.supports() method was introduced by whatwg/html#7008. HTMLScriptElement.supports('importmap') must return true when supported. Fixes WICG#171
horo-t
added a commit
to horo-t/alternate-loading-modes
that referenced
this pull request
Sep 6, 2021
The HTMLScriptElement.supports() method was introduced by whatwg/html#7008. HTMLScriptElement.supports('speculationrules') must return true when supported.
domenic
pushed a commit
to horo-t/import-maps
that referenced
this pull request
Sep 9, 2021
The HTMLScriptElement.supports() method was introduced by whatwg/html#7008. HTMLScriptElement.supports('importmap') must return true when supported. Fixes WICG#171
domenic
pushed a commit
to WICG/import-maps
that referenced
this pull request
Sep 10, 2021
The HTMLScriptElement.supports() method was introduced by whatwg/html#7008. This makes HTMLScriptElement.supports('importmap') return true. Fixes #171.
horo-t
added a commit
to horo-t/html
that referenced
this pull request
Sep 15, 2021
This PR reflects the feedback from the TAG review: w3ctag/design-reviews#674 The original HTMLScriptElement.supports() was introduced by whatwg#7008.
horo-t
added a commit
to horo-t/alternate-loading-modes
that referenced
this pull request
Sep 21, 2021
The HTMLScriptElement.supports() method was introduced by whatwg/html#7008. HTMLScriptElement.supports('speculationrules') must return true when supported.
jeremyroman
pushed a commit
to WICG/nav-speculation
that referenced
this pull request
Sep 21, 2021
The HTMLScriptElement.supports() method was introduced by whatwg/html#7008. HTMLScriptElement.supports('speculationrules') must return true when supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See WHATWG Working Mode: Changes for more details.)
/acknowledgements.html ( diff )
/infrastructure.html ( diff )
/scripting.html ( diff )